Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only resources which files exist are available as job inputs #920

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Only resources which files exist are available as job inputs #920

wants to merge 1 commit into from

Conversation

jackyyzhang03
Copy link
Contributor

@jackyyzhang03 jackyyzhang03 commented May 29, 2023 •
edited
Loading

Resolves: (#625)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

(Describe the changes you've made and the purpose of this PR)

  • In available resources, filter only resources that have a file (i.e. exclude files still being generated)

@jackyyzhang03 jackyyzhang03 self-assigned this May 29, 2023
@jackyyzhang03 jackyyzhang03 linked an issue May 29, 2023 that may be closed by this pull request
rodan allows files that don't exist to appear in avaibable input port resources (idiot-proofing request) #625
Open
@jackyyzhang03 jackyyzhang03 marked this pull request as ready for review May 29, 2023 20:49
@jackyyzhang03 jackyyzhang03 changed the title Only resources whose files exist are available as job inputs Only resources which files exist are available as job inputs Jun 6, 2023
cadagong
cadagong reviewed Jul 3, 2023
View reviewed changes
Copy link
Contributor

@cadagong cadagong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js part looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadagong cadagong cadagong left review comments

@sabrina0822 sabrina0822 Awaiting requested review from sabrina0822

At least 1 approving review is required to merge this pull request.

Assignees

@jackyyzhang03 jackyyzhang03

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rodan allows files that don't exist to appear in avaibable input port resources (idiot-proofing request)
2 participants
@jackyyzhang03 @cadagong